Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use_master when fetching external export metadata information #1760

Merged
merged 4 commits into from
Apr 8, 2020
Merged

use_master when fetching external export metadata information #1760

merged 4 commits into from
Apr 8, 2020

Conversation

WinnyTroy
Copy link
Contributor

@WinnyTroy WinnyTroy commented Jan 8, 2020 •
edited
Loading

Metadata details for extenal exports are being fetched from the replica database. This may fail if the record may still not be available in read replica.

Fixes #1758

@WinnyTroy WinnyTroy requested a review from ukanga January 8, 2020 13:07
ukanga
ukanga requested changes Jan 9, 2020
View reviewed changes
onadata/apps/viewer/tests/test_exports.py Outdated Show resolved Hide resolved
onadata/libs/utils/export_tools.py Show resolved Hide resolved
ivermac
ivermac suggested changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@ivermac ivermac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good but can we test it by mocking? Check this link and search for ....side_effect can also be an iterable which can guide us on how to mock this

@ivermac
Copy link
Contributor

ivermac commented Jan 27, 2020

Found the following as well but I forgot to post
https://stackoverflow.com/questions/13358939/python-mock-side-effect-or-return-value-dependent-on-call-count

@WinnyTroy WinnyTroy force-pushed the export_async_endpoint_fix branch 2 times, most recently from 5b039e6 to 45561d9 Compare April 6, 2020 08:51
ivermac
ivermac previously approved these changes Apr 6, 2020
View reviewed changes
Copy link
Contributor

@ivermac ivermac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

DavisRayM
DavisRayM previously approved these changes Apr 6, 2020
View reviewed changes
Copy link
Contributor

@DavisRayM DavisRayM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, have a few suggestions and comments.

@WinnyTroy
Include mock tests
71c8328 
Fix failing Tests
@WinnyTroy WinnyTroy dismissed stale reviews from DavisRayM and ivermac via 71c8328 April 7, 2020 14:46
DavisRayM
DavisRayM approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@DavisRayM DavisRayM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DavisRayM DavisRayM merged commit 94a7957 into master Apr 8, 2020
@DavisRayM DavisRayM deleted the export_async_endpoint_fix branch April 8, 2020 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ukanga ukanga ukanga approved these changes

@ivermac ivermac ivermac approved these changes

@DavisRayM DavisRayM DavisRayM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

module 'onadata.apps.main.models.meta_data' has no attribute 'DoesNotExist'
4 participants
@WinnyTroy @ivermac @ukanga @DavisRayM